Code tidy up

geeksforsocialchange · Oct 24, 2022 · cbcf04d · cbcf04d
1 parent dd13661
commit cbcf04d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -22,7 +22,7 @@ def user_not_authorized
   end
 
   def resource_not_found
-    render 'pages/resource_not_found', status: 404
+    render 'pages/resource_not_found', status: :not_found
   end
 
   # Set the day either using the URL or by today's date

diff --git a/app/models/neighbourhood.rb b/app/models/neighbourhood.rb
@@ -102,10 +102,6 @@ def find_from_postcodesio_response(res)
                              unit_code_value: res['codes']['admin_ward'],
                              unit_name: res['admin_ward'])
     end
-
-    def expand_name_abbreviations(input_name)
-
-    end
   end
 
   private

diff --git a/test/integration/event_integration_test.rb b/test/integration/event_integration_test.rb
@@ -41,10 +41,9 @@ class EventIntegrationTest < ActionDispatch::IntegrationTest
   end
 
   test 'event show with bad ID is user friendly' do
-    get event_url(99999)
+    get event_url(99_999)
     assert_response :not_found
     assert_select 'h1', text: 'Not found'
     assert_select 'p', text: 'The page you were looking for does not exist'
   end
-
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -102,10 +102,6 @@ def find_from_postcodesio_response(res) @@
                                  unit_code_value: res['codes']['admin_ward'],
                                  unit_name: res['admin_ward'])
         end
-        def expand_name_abbreviations(input_name)
-        end
       end
       private
@@ Expand Down @@