Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring(gtest): Introduce gear_commons mailbox to gtest #4010

Merged
merged 47 commits into from
Jul 16, 2024
Merged

refactoring(gtest): Introduce gear_commons mailbox to gtest #4010

merged 47 commits into from
Jul 16, 2024

Conversation

techraed
Copy link
Member

This PR refactors mailbox logic in the gtest fixing some error inconsistencies with the runtime and, mainly, adding gear_common version of Mailbox.

@techraed
Port gas tree into gtest
47d5769
@techraed
Fix CI, introduce System singleton
3e48d8b
@techraed
Todos
9bea502
@techraed
Fix auxiliary use
cf5ab4e
@techraed
Trigger CI
85d479a
@techraed
Fix tests
2211e7f
@techraed
Make System panic on second instance creation, adjust test
ef5078e
@techraed
Introduce alias, fmt
5300294
@techraed
feat(gtest): Introduce gas allowance to gtest (#3996)
cf0693d
@techraed
Apply review results #1
c429766
@techraed
Remove re-export
768f0e0
@techraed
feat(gear-common,gtest): Introduce proper mailbox for gtest (part 1) (
c2906fc 
#3999)
@techraed
Port gas tree into gtest
39f6ae5
@techraed
Fix CI, introduce System singleton
1fc6d3d
@techraed
Trigger CI
57f4722
@techraed
Make System panic on second instance creation, adjust test
ab1d30f
@techraed
Separate block info management
d36ee5f
@techraed
Introduce a separate auxiliary module for all auxiliary ds
72ce684
@techraed
Introduce auxiliary mailbox
40137e1
@techraed
Rename module
30c279d
@techraed
Add docs, fmt
1813b6d
@techraed
Fix check & clippy
52d4b6a
@techraed
Port gas tree into gtest
7dd7eb8
@techraed
Fix CI, introduce System singleton
c762b14
@techraed
Trigger CI
9704665
@techraed
Make System panic on second instance creation, adjust test
a9ee843
@techraed
Separate block info management
acd6b58
@techraed
Introduce a separate auxiliary module for all auxiliary ds
70c54bc
@techraed
Introduce auxiliary mailbox
69866b0
@techraed
Introduce auxiliary mailbox to gtest
8337915
@techraed techraed added D4-test Autotests, and examples D5-tooling Helper tools and utilities labels Jun 13, 2024
@techraed techraed self-assigned this Jun 13, 2024
@techraed techraed added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Jun 15, 2024
@techraed techraed requested review from ark0f and breathx and removed request for ark0f June 15, 2024 13:07
ark0f
ark0f requested changes Jun 17, 2024
View reviewed changes
gtest/src/blocks.rs Outdated Show resolved Hide resolved
gtest/src/blocks.rs Outdated Show resolved Hide resolved
gtest/src/mailbox/interface.rs Outdated Show resolved Hide resolved
gtest/src/mailbox/interface.rs Outdated Show resolved Hide resolved
gtest/src/program.rs Outdated Show resolved Hide resolved
@techraed techraed mentioned this pull request Jul 1, 2024
Closed
@breathx
Copy link
Member

breathx commented Jul 7, 2024

@techraed any updates here?

@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Jul 7, 2024
@techraed techraed added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Jul 15, 2024
@techraed techraed requested a review from ark0f July 16, 2024 07:47
@techraed techraed added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Jul 16, 2024
@techraed techraed merged commit 5cfb148 into master Jul 16, 2024
18 checks passed
@techraed techraed deleted the st-gtest-mailbox2 branch July 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ark0f ark0f ark0f approved these changes

@breathx breathx Awaiting requested review from breathx

Assignees

@techraed techraed

Labels
A2-mergeoncegreen PR is ready to merge after CI passes D4-test Autotests, and examples D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techraed @breathx @ark0f