Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gear-common,gtest): Introduce proper mailbox for gtest (part 1) #3999

Merged
merged 12 commits into from
Jun 11, 2024
Merged

feat(gear-common,gtest): Introduce proper mailbox for gtest (part 1) #3999

merged 12 commits into from
Jun 11, 2024

Conversation

techraed
Copy link
Member

@techraed techraed commented Jun 5, 2024

Some changes needed to port mailbox from gear-common to gtest:

  • Introduce AuxiliaryMailbox for non-wasm (std) env.
  • change blocks data management, so block data is accessible as it is on pallet (no context global storage). That's needed to implement properly mailbox callbacks.

@techraed techraed self-assigned this Jun 5, 2024
@techraed
Copy link
Member Author

techraed commented Jun 5, 2024

to be merged after #3996

@techraed techraed added A0-pleasereview PR is ready to be reviewed by the team A5-dontmerge PR should not be merged yet D4-test Autotests, and examples D5-tooling Helper tools and utilities and removed D4-test Autotests, and examples labels Jun 5, 2024
Base automatically changed from st-gtest-gas-allowance to st-gas-tree-gtest June 5, 2024 17:36
@techraed techraed requested a review from ark0f June 6, 2024 12:55
techraed
techraed commented Jun 6, 2024
View reviewed changes
common/src/auxiliary/mod.rs Outdated Show resolved Hide resolved
gtest/src/blocks.rs Outdated Show resolved Hide resolved
gtest/src/manager.rs Outdated Show resolved Hide resolved
gtest/src/blocks.rs Outdated Show resolved Hide resolved
breathx
breathx approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@breathx breathx removed A0-pleasereview PR is ready to be reviewed by the team D5-tooling Helper tools and utilities labels Jun 11, 2024
@breathx breathx added the A2-mergeoncegreen PR is ready to merge after CI passes label Jun 11, 2024
@breathx
Copy link
Member

breathx commented Jun 11, 2024

@techraed managing merging order is on you

@techraed techraed merged commit fd004ff into st-gas-tree-gtest Jun 11, 2024
@techraed techraed deleted the st-gtest-mailbox branch June 11, 2024 19:36
techraed added a commit that referenced this pull request Jun 13, 2024
@techraed
feat(gear-common,gtest): Introduce proper mailbox for gtest (part 1) (
c2906fc 
#3999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx approved these changes

@ark0f ark0f ark0f approved these changes

Assignees

@techraed techraed

Labels
A2-mergeoncegreen PR is ready to merge after CI passes A5-dontmerge PR should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techraed @breathx @ark0f