Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

Upgrade to ember 2.0.0-beta.1 and ember-data 1.0.0-beta.19.2 #54

Merged
merged 13 commits into from
Jun 15, 2015

Conversation

jpadilla
Copy link
Collaborator

Only two deprecation warnings left at this point.

  1. Ember.reduceComputed is deprecated. Replace it with plain array methods.
  2. Ember.View is deprecated. Referring to views/packages/list.js.

Don't merge yet. I'll try to work with the latter.

jpadilla added 4 commits June 13, 2015 07:28
The only thing that was preventing this from
happening was `computedFilterByQuery` from
`ember-cli-filter-query`.

I've included utils/filter-by-query which fixes
the issue we were having.
@jpadilla jpadilla had a problem deploying to ember-cli-addon-search-pr-54 June 13, 2015 11:58 Failure
@jpadilla jpadilla deployed to ember-cli-addon-search-pr-54 June 13, 2015 12:49 Active
@jpadilla
Copy link
Collaborator Author

Just replaced views/packages/list.js with a component em-pagination.

@gcollazo
Copy link
Owner

@jpadilla I get an error when Ember Inspector is open.
Uncaught TypeError: Ember.View.addMutationListener is not a function

@jpadilla
Copy link
Collaborator Author

Not sure where that issue stands today.

emberjs/ember-inspector#315
emberjs/ember.js#10412
https://github.com/emberjs/ember.js/search?utf8=%E2%9C%93&q=addMutationListener

Update: Still happens after building ember-inspector from master.

@jpadilla
Copy link
Collaborator Author

Thanks to @teddyzeenny for fixing this issue in emberjs/ember-inspector#393

@jpadilla jpadilla deployed to ember-cli-addon-search-pr-54 June 15, 2015 13:04 Active
@jpadilla
Copy link
Collaborator Author

@gcollazo fixed search filtering, and got tests passing except on ember-beta and ember-canary scenarios.

@jpadilla
Copy link
Collaborator Author

Using different scenarios with ember-try might be an overkill for this case, this is not an addon, and we don't have to support multiple versions of Ember.js at a time. We could keep ember-try around and just have our default scenario which would be whatever version of Ember.js we're using at the time. Thoughts?

@jpadilla
Copy link
Collaborator Author

Ready to merge

gcollazo pushed a commit that referenced this pull request Jun 15, 2015
Upgrade to ember 2.0.0-beta.1 and ember-data 1.0.0-beta.19.2
@gcollazo gcollazo merged commit 5b6f0c6 into gcollazo:master Jun 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants