Fixes for Ember >= 1.13 #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! I was able to fire up the bookmarklet and everything loaded as expected. Thanks again! |
| }, | ||
|
|
||
| viewRegistry: computed('application', function() { | ||
| return Ember.View.views || this.get('application.__container__').lookup('-view-registry:main'); |
There was a problem hiding this comment.
I think the order here should be reversed. In 1.13 Ember.View.views should be present (for legacy support).
Can you confirm (I'm on mobile ATM)? Also, if Ember.View.views (but we should still be using -view-registry if present) is not present on 1.13 I think that is also a bug...
There was a problem hiding this comment.
I reversed the order. You are right, I found the bug on 1.13 that removed Ember.View.views. PRing a fix to Ember core in a bit.
teddyzeenny
force-pushed
the
fix-namespace
branch
from
a02c6b0 to
0b9cfce
Compare
- Renamed `Ember.Debug` to `Ember.EmberInspectorDebugger` - Removed any calls to `Ember.View.addMutationListener` - Use `-view-registry:main` instead of `Ember.View.views`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.DebugtoEmber.EmberInspectorDebuggerEmber.View.addMutationListener-view-registry:maininstead ofEmber.View.viewsFixes #392
Fixes #315