Add World::ValidateGraphs method (sdf9) #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The graph data is private, so expose a method for checking that the graphs are valid. Signed-off-by: Steve Peters <[email protected]>
chapulina
reviewed
Jun 25, 2021
Load an sdf::World instead of an sdf::Root to see the graph errors. Signed-off-by: Steve Peters <[email protected]>
chapulina
approved these changes
Jun 28, 2021
Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
world_validate_graphs_9
branch
from
82e2909 to
8a4fc3c
Compare
Signed-off-by: Steven Peters <[email protected]>
|
I added |
azeey
approved these changes
Jun 30, 2021
Merged
jennuine
pushed a commit
that referenced
this pull request
Jul 29, 2021
The graph data is private, so expose methods for checking that the graphs are valid. * Add tests showing graph errors Load an sdf::World or sdf::Model instead of an sdf::Root to see the graph errors. Signed-off-by: Steve Peters <[email protected]> Signed-off-by: Jenn Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
I noticed a bug in ign-physics that needs a new API in libsdformat to properly fix it. This is similar to #601 but is targeted at
sdf9.Summary
I noticed a test in ign-physics in which some models do not have properly loaded graphs, but it's hard to detect since the graph data is private. This creates a
World::ValidateGraphs()method to call the hiddenvalidate*Graphfunctions in FrameSemantics.cc with the private graph data. It also requires an extra check in thevalidate*Graphfunctions that the scope points to a valid graph.Test it
Run the
UNIT_World_TESTandINTEGRATION_world_domtests and see that they pass.Checklist
sh tools/code_check.sh)another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge