Fix macOS workflow and backport windows fix #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `gz sdf` tests are fixed by * fixing dll path issue with Ruby on windows * Setting home path --------- Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
changed the title
gz sdf tests on Windows (#1374)gz sdf tests on Windows (#1374)"
azeey
changed the title
gz sdf tests on Windows (#1374)"gz sdf tests on Windows (#1374)"
iche033
approved these changes
May 9, 2024
scpeters
approved these changes
May 10, 2024
scpeters
changed the title
gz sdf tests on Windows (#1374)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
Partially backports #1374 to fix #1321
This also fixes the macOS workflow in 5a8751e, so I think we'll need to squash and merge.
Note to maintainers: Remember to Squash and Merge