Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gz sdf still not on Windows? #1321

Closed
peci1 opened this issue Sep 3, 2023 · 3 comments · Fixed by #1339
Closed

gz sdf still not on Windows? #1321

peci1 opened this issue Sep 3, 2023 · 3 comments · Fixed by #1339
Assignees

Comments

@peci1
Copy link
Contributor

peci1 commented Sep 3, 2023

sdformat/src/CMakeLists.txt

Lines 129 to 131 in 881cbb7

if(NOT WIN32)
add_subdirectory(cmd)
endif()

Any reason why this is still there? What is the blocker?

@peci1
Copy link
Contributor Author

peci1 commented Sep 3, 2023

Bad thing is gz sdf command is actually registered to gz-tools, so it is presented in help messages etc., but the ruby script is not installed, so any attempt at running it fails with a cryptic error.

@traversaro
Copy link
Contributor

traversaro commented Sep 3, 2023

See gazebosim/gz-tools#71 for a related discussion. In a nutshell we need to propagate the fix gazebosim/gz-plugin#63 here, just removing the if I am not wrong will break builds on Visual Studio multiple-config generators.

@peci1
Copy link
Contributor Author

peci1 commented Sep 4, 2023

if if I am not wrong will break builds on Visual Studio multiple-config generators.

You're right ;)

@azeey azeey moved this from Inbox to To do in Core development Sep 18, 2023
@github-project-automation github-project-automation bot moved this from To do to Done in Core development Oct 23, 2023
@azeey azeey reopened this Nov 10, 2023
@github-project-automation github-project-automation bot moved this from Done to Inbox in Core development Nov 10, 2023
@azeey azeey moved this from Inbox to In progress in Core development Nov 10, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Core development May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
4 participants