Merge sdf12 ➡️ main #1024
Merged
Merge sdf12 ➡️ main #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Lew <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Steve Peters <[email protected]>
* Updated CMakeLists and Changelog for release Signed-off-by: William Lew <[email protected]> * Added code suggestions Signed-off-by: William Lew <[email protected]> * Added code suggestion Signed-off-by: William Lew <[email protected]>
Friction parameters are expressed as a material in USD, this change will link the collision with the physics material Signed-off-by: ahcorde <[email protected]> Signed-off-by: Ashton Larkin <[email protected]> Co-authored-by: Ashton Larkin <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
This helps resolve ambiguities in the SDF <inertial> tag by clarifying the link’s center of mass location, explicitly stating that the inertia is always about the link’s center of mass, clarifying the directions associated with moments/products of inertia, and clarifying the ± sign convention for product of inertia. The changes to the 1.5, 1.6, and 1.7 versions of inertial.sdf have slight modifications to account for the presence of //inertial/pose/@frame in 1.5, 1.6 and //inertial/pose/@relative_to in 1.7. Thanks to Paul Mitiguy and Michael Sherman from Toyota Research Institute for these improvements. Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Silvio Traversaro <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 27 27
=======================================
Hits 18 18
Misses 9 9
Continue to review full report at Codecov.
|
iche033
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
sdf12➡️mainBranch comparision: main...sdf12
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)