Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[garden] Added <shininess> to <material> #1018

Closed

Conversation

WilliamLewww
Copy link
Contributor

➡️ Forward port #985

Forward port of #985

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@WilliamLewww WilliamLewww force-pushed the wlew/shininess_garden branch from 3471ba0 to 2e1681f Compare May 12, 2022 19:54
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1018 (68d169c) into main (324a755) will not change coverage.
The diff coverage is n/a.

❗ Current head 68d169c differs from pull request most recent head 7446d8c. Consider uploading reports for the commit 7446d8c to get more accurate results

@@           Coverage Diff           @@
##             main    #1018   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           
Impacted Files Coverage Δ
src/EmbeddedSdf.cc 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324a755...7446d8c. Read the comment docs.

@scpeters
Copy link
Member

I believe this was already merged forward in #1024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants