-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bridging NavSat #224
Conversation
Signed-off-by: Tyler Howell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. The implementation, test and example look great!
The only catch is that this branch is supported with both Citadel and Fortress, but the NavSat
message and the NavSat
sensor are only available from Fortress. So we have a couple of options:
- Add
ifdef
s so theNavSat
is only present onIGN_MSGS_VER >= 8
- Or backport the
NavSat
message toign-msgs5
- while this is trivial, backporting theNavSat
sensor itself isn't. It shouldn't hurt having the message there though.
In any case, we should add a note to ros_ign_gazebo_demos/README.md
that the GNSS example only works from Fortress.
@chapulina @ahcorde Thanks for the reviews I should have a fix :) by the end of the day. |
Signed-off-by: Tyler Howell <[email protected]>
Signed-off-by: Tyler Howell <[email protected]>
ign-msgs5 PR has been submitted that backports NavSat message only. |
Thanks! Here are the next steps:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready! Thanks for the wait!
Authored-by: Tyler Howell <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Tyler Howell <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Tyler Howell <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Co-authored-by: Tyler Howell <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
🎉 New feature
Closes #218
Summary
Adds two-way bridge for NavSat messages between ROS and IGN along with a demo launch file.
Test it
Test IGN->ROS by running
roslaunch ros_ign_gazebo_demos navsat.launch
.Test ROS->IGN by
roslaunch ros_ign_gazebo_demos navsat.launch
andign topic -t /navsat -e
Even using the contributing guides I was unable to get codecheck or the tests running :(
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.