Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 to 4 #916

Merged
merged 4 commits into from
Jul 14, 2021
Merged

3 to 4 #916

merged 4 commits into from
Jul 14, 2021

Conversation

adlarkin
Copy link
Contributor

➡️ Forward port

Port ign-gazebo3 to ign-gazebo4

Branch comparison: ign-gazebo4...ign-gazebo3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

iche033 and others added 3 commits June 24, 2021 14:51
* fix mouse view control race condition

Signed-off-by: Ian Chen <[email protected]>

* add dragging

Signed-off-by: Ian Chen <[email protected]>
@adlarkin adlarkin requested review from mjcarroll and chapulina July 13, 2021 23:12
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jul 13, 2021
@adlarkin adlarkin changed the title Adlarkin/3 to 4 3 to 4 Jul 13, 2021
Signed-off-by: Ashton Larkin <[email protected]>
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #916 (488cc87) into ign-gazebo4 (e3fbbcd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #916      +/-   ##
===============================================
- Coverage        66.00%   65.98%   -0.02%     
===============================================
  Files              239      239              
  Lines            17681    17686       +5     
===============================================
  Hits             11670    11670              
- Misses            6011     6016       +5     
Impacted Files Coverage Δ
include/ignition/gazebo/components/Sensor.hh 100.00% <ø> (ø)
src/gui/plugins/scene3d/Scene3D.cc 9.93% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3fbbcd...488cc87. Read the comment docs.

@adlarkin adlarkin merged commit 488cc87 into ign-gazebo4 Jul 14, 2021
@adlarkin adlarkin deleted the adlarkin/3_to_4 branch July 14, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants