Use UINT64_MAX for kComponentTpyeIdInvalid instead of relying on underflow

[adlarkin]

Signed-off-by: Ashton Larkin [email protected]

🦟 Bug fix

Summary

kComponentTypeIdInvalid was defined as -1. However, the type for this alias variable is ComponentTypeId, which is uint64_t. So, using -1 results in underflow. While this shouldn't be a problem if we're always using the alias, I've explicitly set the invalid type alias to UINT64_MAX to prevent any weird bugs that may arise from underflow.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #889 (81c21bf) into ign-gazebo3 (279e4ff) will increase coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-gazebo3     #889      +/-   ##
===============================================
+ Coverage        77.90%   77.94%   +0.04%     
===============================================
  Files              215      215              
  Lines            12077    12077              
===============================================
+ Hits              9408     9414       +6     
+ Misses            2669     2663       -6     

Impacted Files	Coverage Δ
src/SimulationRunner.cc	94.42% <0.00%> (+1.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279e4ff...81c21bf. Read the comment docs.

[chapulina]

😅