add heat signature option to thermal system #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlarkin
force-pushed
the
adlarkin/heat_signature
branch
2 times, most recently
from
69258d5 to
70c4015
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #498 +/- ##
===============================================
+ Coverage 77.29% 77.44% +0.14%
===============================================
Files 208 216 +8
Lines 11198 12079 +881
===============================================
+ Hits 8655 9354 +699
- Misses 2543 2725 +182
Continue to review full report at Codecov.
|
3 tasks
adlarkin
commented
Jan 13, 2021
nkoenig
reviewed
Jan 25, 2021
iche033
reviewed
Jan 26, 2021
There was a problem hiding this comment.
a couple todos from discussion:
- Look into path issue with models: I had to update the thermal texture path in model.sdf for rescue randy and phone to load (they were all lowercase and ign-gazebo couldn't load them for me). Not sure why
- add an integration test
adlarkin
commented
Jan 27, 2021
iche033
reviewed
Jan 27, 2021
iche033
reviewed
Feb 1, 2021
iche033
approved these changes
Feb 1, 2021
|
I will merge this once I have updated the fuel models used in the example/tests worlds as mentioned here |
Signed-off-by: Ashton Larkin <[email protected]>
adlarkin
force-pushed
the
adlarkin/heat_signature
branch
from
5612a48 to
b4e152d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how this may be useful, take a look at gazebosim/gz-rendering#189.
Makes use of #578 as well.
TODO
TemperatureRangecomponentSigned-off-by: Ashton Larkin [email protected]