3 ➡️ 4 #410
Merged
3 ➡️ 4 #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
… model feature Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: John Shepherd <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
* initial version of wheel_slip system copied from apply_joint_force * Port essential parts of WheelSlipPlugin * Add test init and resolve comments Signed-off-by: John Shepherd <[email protected]> * updated tests Signed-off-by: John Shepherd <[email protected]> * add tricycle uphill test Signed-off-by: John Shepherd <[email protected]> * Add partial tire drum test Signed-off-by: John Shepherd <[email protected]> * Add triball drift sdf Signed-off-by: John Shepherd <[email protected]> * Sdf changes Signed-off-by: John Shepherd <[email protected]> * initial version of wheel_slip system copied from apply_joint_force * Port essential parts of WheelSlipPlugin * Add test init and resolve comments Signed-off-by: John Shepherd <[email protected]> * updated tests Signed-off-by: John Shepherd <[email protected]> * add tricycle uphill test Signed-off-by: John Shepherd <[email protected]> * Add partial tire drum test Signed-off-by: John Shepherd <[email protected]> * Add triball drift sdf Signed-off-by: John Shepherd <[email protected]> * Sdf changes Signed-off-by: John Shepherd <[email protected]> * requested fixes Signed-off-by: John Shepherd <[email protected]> * Add suggestions, make codecheck happy Signed-off-by: John Shepherd <[email protected]> * Add test fixes Signed-off-by: John Shepherd <[email protected]> * Requested fixes Signed-off-by: John Shepherd <[email protected]> * Add suggested fixes Signed-off-by: John Shepherd <[email protected]> * Update src/systems/wheel_slip/WheelSlip.cc Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: John Shepherd <[email protected]>
A recent update to DART changed the way the slip parameter is implemented. Part of this change removed the small amount of slip each surface had by default. This in turn broke this test because the vehicle would not steer as some amount of slip is needed in the lateral direction. The solution is to lower the coefficient of friction in the lateral direction so the friction in that direction can be overcome by the steering force. Signed-off-by: Addisu Z. Taddese <[email protected]>
* enhanced log playback performance Signed-off-by: Ashton Larkin <[email protected]> * Handling multiple Parse(...) calls in a single Update Signed-off-by: Ashton Larkin <[email protected]> * Change clear behavior Signed-off-by: Nate Koenig <[email protected]> * Revert changes Signed-off-by: Nate Koenig <[email protected]> * explain cached pose clearing behavior Signed-off-by: Ashton Larkin <[email protected]> * fixed whitespacing for codecheck Signed-off-by: Ashton Larkin <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
* 2.25.0 Signed-off-by: Nate Koenig <[email protected]> * Added missing PR Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: John Shepherd <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: John Shepherd <[email protected]> Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
chapulina
added
the
needs upstream release
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/3_to_4
branch
from
bd37fde to
75aed3e
Compare
chapulina
removed
the
needs upstream release
|
|
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #410 +/- ##
===============================================
+ Coverage 77.19% 77.21% +0.01%
===============================================
Files 200 203 +3
Lines 10709 10963 +254
===============================================
+ Hits 8267 8465 +198
- Misses 2442 2498 +56
Continue to review full report at Codecov.
|
|
@osrf-jenkins run tests please |
Signed-off-by: Louise Poubel <[email protected]>
Thanks for figuring this out, @azeey. The test was failing locally for me and I was thinking I had the wrong DART version. Reverted in 0ab6d35 and confirmed that the test is fixed for me locally 👍 |
azeey
approved these changes
Oct 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port
ign-gazebo3toign-gazebo4. See comparison:ign-gazebo4...ign-gazebo3
Needs this PR to be merged and released first: gazebosim/gz-physics#129