Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 -> 5 #1360

Merged
merged 3 commits into from
Feb 24, 2022
Merged

3 -> 5 #1360

merged 3 commits into from
Feb 24, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 24, 2022

➡️ Forward port

Port ign-gazebo3 to ign-gazebo5

Branch comparison: ign-gazebo5...ign-gazebo3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@iche033 iche033 requested a review from chapulina as a code owner February 24, 2022 05:27
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1360 (f96558f) into ign-gazebo5 (211289f) will increase coverage by 0.13%.
The diff coverage is 89.91%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo5    #1360      +/-   ##
===============================================
+ Coverage        66.91%   67.04%   +0.13%     
===============================================
  Files              276      276              
  Lines            20930    21049     +119     
===============================================
+ Hits             14005    14112     +107     
- Misses            6925     6937      +12     
Impacted Files Coverage Δ
src/systems/scene_broadcaster/SceneBroadcaster.cc 94.94% <88.34%> (-1.93%) ⬇️
...stems/joint_state_publisher/JointStatePublisher.cc 83.60% <100.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211289f...f96558f. Read the comment docs.

@mjcarroll mjcarroll merged commit b45f60f into ign-gazebo5 Feb 24, 2022
@mjcarroll mjcarroll deleted the merge_3_5_20220223 branch February 24, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants