Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more sensor properties to scene/info topic #1344

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 16, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Topic /world/<world_name>/scene/info is sending some data about the sensor, but it's just the id, parent, name and pose. There is no data about the sensor itself. I don't know if this is intended.

This PR add property data to:

  • Camera
  • Lidar
  • IMU

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from chapulina as a code owner February 16, 2022 14:14
@ahcorde ahcorde self-assigned this Feb 16, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Feb 16, 2022
@adlarkin adlarkin self-requested a review February 16, 2022 17:14
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1344 (dd683fb) into ign-gazebo3 (08a0dfc) will increase coverage by 0.07%.
The diff coverage is 88.34%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1344      +/-   ##
===============================================
+ Coverage        77.74%   77.82%   +0.07%     
===============================================
  Files              248      248              
  Lines            14239    14342     +103     
===============================================
+ Hits             11070    11161      +91     
- Misses            3169     3181      +12     
Impacted Files Coverage Δ
src/systems/scene_broadcaster/SceneBroadcaster.cc 95.56% <88.34%> (-2.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a0dfc...dd683fb. Read the comment docs.

@ahcorde ahcorde requested a review from mjcarroll February 18, 2022 09:16
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one typo

components::AirPressureSensor>(_entity);
if (airPressureComp)
{
sensorMsg->set_type("air_preasure");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sensorMsg->set_type("air_preasure");
sensorMsg->set_type("air_pressure");

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde merged commit 64755e5 into ign-gazebo3 Feb 18, 2022
@ahcorde ahcorde deleted the ahcorde/3/scene_info_sensors branch February 18, 2022 16:21
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants