-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more sensor properties to scene/info topic #1344
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1344 +/- ##
===============================================
+ Coverage 77.74% 77.82% +0.07%
===============================================
Files 248 248
Lines 14239 14342 +103
===============================================
+ Hits 11070 11161 +91
- Misses 3169 3181 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one typo
components::AirPressureSensor>(_entity); | ||
if (airPressureComp) | ||
{ | ||
sensorMsg->set_type("air_preasure"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sensorMsg->set_type("air_preasure"); | |
sensorMsg->set_type("air_pressure"); |
Signed-off-by: ahcorde <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
Topic
/world/<world_name>/scene/info
is sending some data about the sensor, but it's just the id, parent, name and pose. There is no data about the sensor itself. I don't know if this is intended.This PR add property data to:
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.