Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply noise evenly to scans and point clouds #89

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Feb 3, 2021

Forward ports #86 to Edifice, making use of gazebosim/gz-rendering#229.

@nkoenig nkoenig requested a review from iche033 as a code owner February 3, 2021 21:41
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 3, 2021
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing, presumably because this needs an ign-rendering release?

Signed-off-by: Michael Carroll <[email protected]>
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #89 (35baaa4) into main (01aed17) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   76.13%   76.19%   +0.05%     
==========================================
  Files          23       23              
  Lines        2388     2394       +6     
==========================================
+ Hits         1818     1824       +6     
  Misses        570      570              
Impacted Files Coverage Δ
src/GpuLidarSensor.cc 87.26% <100.00%> (+0.16%) ⬆️
src/Lidar.cc 71.79% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01aed17...35baaa4. Read the comment docs.

@mjcarroll mjcarroll self-assigned this Mar 8, 2021
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Mar 17, 2021
@mjcarroll mjcarroll merged commit 82c3165 into main Mar 24, 2021
@mjcarroll mjcarroll deleted the lidar_noise_and_resolution branch March 24, 2021 22:05
chapulina added a commit that referenced this pull request Mar 26, 2021
chapulina added a commit that referenced this pull request Mar 26, 2021
Revert "Apply noise evenly to scans and point clouds (#89)" and prep for 5.0.0~pre2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants