Support setting horizontal and vertical resolution for GpuRays

[nkoenig]

This allows horizontal and vertical resolution to be set on GpuRays.

This problem was found in Citadel (see here), but applying a non-breaking change to Citadel proved difficult.

Signed-off-by: Nate Koenig [email protected]

[codecov]

Codecov Report

Merging #229 (80427ef) into main (b04a527) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   56.98%   57.01%   +0.02%     
==========================================
  Files         151      151              
  Lines       15000    15010      +10     
==========================================
+ Hits         8548     8558      +10     
  Misses       6452     6452              

Impacted Files	Coverage Δ
include/ignition/rendering/GpuRays.hh	0.00% <ø> (ø)
include/ignition/rendering/base/BaseGpuRays.hh	77.10% <100.00%> (+3.13%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04a527...80427ef. Read the comment docs.

[iche033]

changes looks good to me. Waiting for Windows CI fix in #228

[iche033]

CI looks good. Just some windows warnings:
https://build.osrfoundation.org/job/ign_rendering-pr-win/1288/msbuild/

[mjcarroll]

Looks good.

I think that there needs to be some documentation of what the units of the resolution parameters are. I think it's supposed to be radians/increment, but I'm not 100% positive.

[mjcarroll]

@osrf-jenkins retest this please

[nkoenig]

Looks good.

I think that there needs to be some documentation of what the units of the resolution parameters are. I think it's supposed to be radians/increment, but I'm not 100% positive.

I added more documentation in f41df65. Resolution is a factor and unitless.

[mjcarroll]

Thanks for adding the doc, CI failure is unrelated.