Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msgs and transport version in Harmonic #316

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 11, 2023

🎉 New feature

Summary

Bumping to use the new msgs and transport versions in Harmonic, msgs10 and transport13

gazebo-tooling/release-tools#878

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #316 (9ab6307) into main (0440bec) will not change coverage.
The diff coverage is n/a.

❗ Current head 9ab6307 differs from pull request most recent head 80de3b8. Consider uploading reports for the commit 80de3b8 to get more accurate results

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   72.08%   72.08%           
=======================================
  Files          38       38           
  Lines        4800     4800           
=======================================
  Hits         3460     3460           
  Misses       1340     1340           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 marked this pull request as draft February 11, 2023 03:34
Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor Author

iche033 commented Feb 16, 2023

Ubuntu CI should be fixed by a new transport13 nightly once this PR gets in: gazebo-release/gz-transport13-release#2

homebrew CI needs: osrf/homebrew-simulation#2208

windows: gazebo-tooling/gazebodistro#132

@iche033
Copy link
Contributor Author

iche033 commented Feb 17, 2023

@osrf-jenkins run tests please

@iche033 iche033 marked this pull request as ready for review February 18, 2023 01:52
@iche033
Copy link
Contributor Author

iche033 commented Feb 18, 2023

CIs are green. PR is ready for review

@iche033 iche033 merged commit 4075656 into main Feb 21, 2023
@iche033 iche033 deleted the bump_msgs_transport branch February 21, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants