Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed light visual in OGRE #862

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Fixed light visual in OGRE #862

merged 3 commits into from
Jun 9, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 9, 2023

🦟 Bug fix

Summary

Related with this issue gazebosim/gz-sim#1948

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #862 (d62d996) into gz-rendering7 (f192e4f) will not change coverage.
The diff coverage is n/a.

❗ Current head d62d996 differs from pull request most recent head 612c35d. Consider uploading reports for the commit 612c35d to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #862   +/-   ##
==============================================
  Coverage          77.14%   77.14%           
==============================================
  Files                170      170           
  Lines              14715    14715           
==============================================
  Hits               11352    11352           
  Misses              3363     3363           

@ahcorde ahcorde enabled auto-merge (squash) June 9, 2023 15:51
@ahcorde ahcorde merged commit 537bcea into gz-rendering7 Jun 9, 2023
@ahcorde ahcorde deleted the ahcorde/fix/light_ogre branch June 9, 2023 21:42
ahcorde added a commit that referenced this pull request Jun 12, 2023
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
ahcorde added a commit that referenced this pull request Jun 12, 2023
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants