Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport fortress] Fixed light visual in OGRE (#862) #864

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 12, 2023

🦟 Bug fix

Summary

Related with this issue gazebosim/gz-sim#1948 and backport #862

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from iche033 as a code owner June 12, 2023 10:09
@ahcorde ahcorde self-assigned this Jun 12, 2023
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #864 (b84838e) into ign-rendering6 (9421565) will not change coverage.
The diff coverage is n/a.

❗ Current head b84838e differs from pull request most recent head 65a1c9c. Consider uploading reports for the commit 65a1c9c to get more accurate results

@@               Coverage Diff               @@
##           ign-rendering6     #864   +/-   ##
===============================================
  Coverage           79.61%   79.61%           
===============================================
  Files                 146      146           
  Lines               13445    13445           
===============================================
  Hits                10704    10704           
  Misses               2741     2741           

@ahcorde ahcorde changed the base branch from gz-rendering7 to ign-rendering6 June 12, 2023 14:04
@ahcorde ahcorde force-pushed the ahcorde/fortress/backport/862 branch from adbc149 to 65a1c9c Compare June 12, 2023 14:05
@ahcorde ahcorde merged commit 6ea5ede into ign-rendering6 Jun 12, 2023
@ahcorde ahcorde deleted the ahcorde/fortress/backport/862 branch June 12, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants