👩🌾 Make GitHub actions tests that are flaky due to display more verbose #255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug exploration
Summary
Our tests on
ign-rendering
andign-gui
occasionally fail on GitHub actions because they can't open the display, see more info on gazebosim/gz-gui#58.This is an attempt of making the display tests more robust (with the new arguments passed to
Xvfb
) and failures more verbose (with the updated error messages onOgre2RenderEngine
).Unfortunately, the failure is so rare that I haven't been able to get a failure message with this branch yet. It should come with time, unless the changes to the
Xvfb
invocation really fix it.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
https://github.com/osrf/buildfarmer/issues/161