Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 Make GitHub actions tests that are flaky due to display more verbose #255

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug exploration

Summary

Our tests on ign-rendering and ign-gui occasionally fail on GitHub actions because they can't open the display, see more info on gazebosim/gz-gui#58.

This is an attempt of making the display tests more robust (with the new arguments passed to Xvfb) and failures more verbose (with the updated error messages on Ogre2RenderEngine).

Unfortunately, the failure is so rare that I haven't been able to get a failure message with this branch yet. It should come with time, unless the changes to the Xvfb invocation really fix it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge


https://github.com/osrf/buildfarmer/issues/161

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the tests Broken or missing tests / testing infra label Feb 24, 2021
@chapulina chapulina requested a review from iche033 as a code owner February 24, 2021 01:11
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 24, 2021
@chapulina chapulina changed the base branch from ign-rendering4 to ign-rendering3 February 24, 2021 01:12
@chapulina chapulina added 🏰 citadel Ignition Citadel and removed 🔮 dome Ignition Dome labels Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #255 (42d6758) into ign-rendering3 (64016f6) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering3     #255      +/-   ##
==================================================
- Coverage           50.59%   50.59%   -0.01%     
==================================================
  Files                 129      129              
  Lines               11882    11887       +5     
==================================================
+ Hits                 6012     6014       +2     
- Misses               5870     5873       +3     
Impacted Files Coverage Δ
ogre2/src/Ogre2RenderEngine.cc 78.80% <33.33%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64016f6...42d6758. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants