Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Light Intensity #233

Merged
merged 6 commits into from
Feb 8, 2021
Merged

Added Light Intensity #233

merged 6 commits into from
Feb 8, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 4, 2021

Added light intensity. Related with this issue #232

Need some releases:

Signed-off-by: ahcorde [email protected]

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde added needs upstream release Blocked by a release of an upstream library 🏢 edifice Ignition Edifice labels Feb 4, 2021
@ahcorde ahcorde requested a review from iche033 February 4, 2021 17:59
@ahcorde ahcorde self-assigned this Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #233 (d0553fa) into main (1f53897) will decrease coverage by 0.00%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   56.98%   56.98%   -0.01%     
==========================================
  Files         151      151              
  Lines       14989    15000      +11     
==========================================
+ Hits         8542     8547       +5     
- Misses       6447     6453       +6     
Impacted Files Coverage Δ
include/ignition/rendering/Light.hh 100.00% <ø> (ø)
ogre/src/OgreLight.cc 0.00% <0.00%> (ø)
include/ignition/rendering/base/BaseLight.hh 100.00% <100.00%> (ø)
ogre2/src/Ogre2Light.cc 98.30% <100.00%> (+0.07%) ⬆️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 96.66% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f53897...d0553fa. Read the comment docs.

Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde merged commit b04a527 into main Feb 8, 2021
@ahcorde ahcorde deleted the ahcorde/light/intensity branch February 8, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice needs upstream release Blocked by a release of an upstream library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants