Added light intensity to light.proto #131
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 7 7
Lines 828 828
=======================================
Hits 702 702
Misses 126 126 Continue to review full report at Codecov.
|
proto/ignition/msgs/light.proto
Outdated
| @@ -55,6 +55,7 @@ message Light | |||
| float spot_inner_angle = 13; | |||
| float spot_outer_angle = 14; | |||
| float spot_falloff = 15; | |||
| float intensity = 18; | |||
There was a problem hiding this comment.
Can we put it in order below? Also, please document all new fields.
Signed-off-by: ahcorde <[email protected]>
| @@ -61,4 +61,7 @@ message Light | |||
|
|
|||
| /// \brief Unique id of light's parent | |||
| uint32 parent_id = 17; | |||
|
|
|||
| /// \brief light intensity | |||
| float intensity = 18; | |||
There was a problem hiding this comment.
can we default this to 1.0?
There was a problem hiding this comment.
Explicit default values are not allowed in proto3.
There was a problem hiding this comment.
@iche033 can we merge this then?
There was a problem hiding this comment.
maybe we can force this as a required field
There was a problem hiding this comment.
ok I see, lets leave it as is then.
Added light intensity field to light.proto. Related with this issue gazebosim/gz-rendering#232
Signed-off-by: ahcorde [email protected]