Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 ➡️ 3 #119

Merged
merged 8 commits into from
Aug 4, 2020
Merged

2 ➡️ 3 #119

merged 8 commits into from
Aug 4, 2020

Conversation

chapulina
Copy link
Contributor

No description provided.

chapulina and others added 7 commits April 17, 2020 14:06
@chapulina
[ign-rendering2] Update BitBucket links
f89c659 
Signed-off-by: Louise Poubel <[email protected]>
@iche033
Merge pull request #63 from ignitionrobotics/github_changelog_ign-ren…
4e3c2d7 
…dering2

[ign-rendering2] Update BitBucket links
[ign-rendering2] Add .gitignore (#67)
90f6cc6 
* mv hgignore
* add gitignore
Signed-off-by: claireyywang <[email protected]>
@iche033
bump 2.4.0 (#66)
1774bea
@chapulina
[ign-rendering2] Workflow updates (#79)
c1e7119 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Fix tests on actions (#115)
3f8eb38 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
2 to 3
e04df8c 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from iche033 as a code owner July 31, 2020 23:15
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 31, 2020
@chapulina
Copy link
Contributor Author

The INTEGRATION_versioned_symbols test is failing on actions but they pass on Jenkins. I just realized these tests don't get generated for me locally, I'm not sure why.

@chapulina chapulina self-assigned this Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020 •
edited
Loading

Codecov Report

Merging #119 into ign-rendering3 will increase coverage by 42.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-rendering3     #119       +/-   ##
===================================================
+ Coverage            7.81%   49.82%   +42.01%     
===================================================
  Files                  25      129      +104     
  Lines                1689    11526     +9837     
===================================================
+ Hits                  132     5743     +5611     
- Misses               1557     5783     +4226
Impacted Files Coverage Δ
ogre/src/OgreThermalCamera.cc 0.00% <ø> (ø)
ogre2/src/Ogre2ThermalCamera.cc 93.68% <ø> (ø)
include/ignition/rendering/ThermalCamera.hh 100.00% <0.00%> (ø)
ogre2/src/Ogre2RenderTargetMaterial.cc 0.00% <0.00%> (ø)
...nclude/ignition/rendering/base/BaseRenderTarget.hh 61.62% <0.00%> (ø)
ogre2/src/Ogre2Mesh.cc 55.00% <0.00%> (ø)
include/ignition/rendering/base/BaseAxisVisual.hh 0.00% <0.00%> (ø)
include/ignition/rendering/base/BaseArrowVisual.hh 0.00% <0.00%> (ø)
ogre2/src/Ogre2Sensor.cc 100.00% <0.00%> (ø)
ogre2/src/Ogre2RayQuery.cc 89.39% <0.00%> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54768c...a879629. Read the comment docs.

@iche033
Copy link
Contributor

iche033 commented Aug 3, 2020 •
edited
Loading

a879629 fixes the INTEGRATION_versioned_symbols_* tests

@chapulina
Copy link
Contributor Author

@osrf-jenkins run tests please

@JShep1 JShep1 self-requested a review August 4, 2020 19:59
JShep1
JShep1 approved these changes Aug 4, 2020
View reviewed changes
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chapulina chapulina merged commit 640d623 into ign-rendering3 Aug 4, 2020
@chapulina chapulina deleted the chapulina/2_to_3_2020-07-31 branch August 4, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JShep1 JShep1 JShep1 approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees

@chapulina chapulina

Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @iche033 @JShep1