Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests on actions #115

Merged
merged 7 commits into from
Jul 31, 2020
Merged

Fix tests on actions #115

merged 7 commits into from
Jul 31, 2020

Conversation

chapulina
Copy link
Contributor

Resolves #44.

Requires gazebo-tooling/action-gz-ci#13

@chapulina
Fix tests on actions
f2e8046 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the tests Broken or missing tests / testing infra label Jul 20, 2020
@chapulina chapulina requested a review from iche033 as a code owner July 20, 2020 21:14
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Jul 20, 2020
@chapulina chapulina linked an issue Jul 20, 2020 that may be closed by this pull request
Renable tests in actions #44
Closed
@chapulina
PR merged
4b6100a 
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jul 20, 2020 •
edited
Loading

Codecov Report

Merging #115 into ign-rendering2 will increase coverage by 42.82%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-rendering2     #115       +/-   ##
===================================================
+ Coverage            7.93%   50.75%   +42.82%     
===================================================
  Files                  24      117       +93     
  Lines                1664     9922     +8258     
===================================================
+ Hits                  132     5036     +4904     
- Misses               1532     4886     +3354
Impacted Files Coverage Δ
ogre/src/OgreGaussianNoisePass.cc 1.81% <0.00%> (ø)
ogre2/src/Ogre2Scene.cc 85.79% <0.00%> (ø)
ogre2/src/Ogre2Camera.cc 87.61% <0.00%> (ø)
include/ignition/rendering/base/BaseCamera.hh 70.27% <0.00%> (ø)
include/ignition/rendering/base/BaseArrowVisual.hh 0.00% <0.00%> (ø)
ogre2/src/Ogre2Light.cc 98.23% <0.00%> (ø)
ogre/src/OgreGeometry.cc 0.00% <0.00%> (ø)
include/ignition/rendering/CompositeVisual.hh 0.00% <0.00%> (ø)
ogre/src/OgreRenderEngine.cc 67.71% <0.00%> (ø)
ogre2/src/Ogre2Node.cc 92.94% <0.00%> (ø)
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e7119...84f1703. Read the comment docs.

@chapulina
move dependencies
7604e6b 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Jul 25, 2020
Merged
@chapulina
packages-bionic
19768b2 
Signed-off-by: Louise Poubel <[email protected]>
This was referenced Jul 27, 2020
Merged
Merged
chapulina added 3 commits July 31, 2020 09:56
@chapulina
use master
adec477 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
add focal
d2783be 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
rename action
84f1703 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 3f8eb38 into ign-rendering2 Jul 31, 2020
@chapulina chapulina deleted the chapulina/actions_tests branch July 31, 2020 22:48
chapulina added a commit that referenced this pull request Jul 31, 2020
@chapulina
Fix tests on actions (#115)
8005d55 
Signed-off-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint tests Broken or missing tests / testing infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renable tests in actions
2 participants
@chapulina @iche033