-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ogre2 tests on windows #109
Conversation
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering3 #109 +/- ##
=================================================
+ Coverage 7.81% 7.86% +0.05%
=================================================
Files 25 25
Lines 1689 1690 +1
=================================================
+ Hits 132 133 +1
Misses 1557 1557
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]>
testing CI, reopen later |
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033 , do you know what's the status of this PR, considering all the other Windows changes that have been merged recently? |
I'm still seeing error msgs in the windows CI build console:
but the tests are actually passing which makes me wonder if these msgs are a red herring. |
closing this PR as I haven't had time to get back to this. |
The changes make sure that ign-rendering-ogre2.dll is loaded when running tests.
Testing windows CI