Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ogre2 tests on windows #109

Closed
wants to merge 6 commits into from
Closed

Run ogre2 tests on windows #109

wants to merge 6 commits into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 30, 2020

The changes make sure that ign-rendering-ogre2.dll is loaded when running tests.

Testing windows CI

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 marked this pull request as draft June 30, 2020 21:49
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #109 (ef1af28) into ign-rendering3 (5ca5ea0) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           ign-rendering3    #109      +/-   ##
=================================================
+ Coverage            7.81%   7.86%   +0.05%     
=================================================
  Files                  25      25              
  Lines                1689    1690       +1     
=================================================
+ Hits                  132     133       +1     
  Misses               1557    1557              
Impacted Files Coverage Δ
src/RenderEngineManager.cc 25.40% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca5ea0...ef1af28. Read the comment docs.

Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor Author

iche033 commented Jun 30, 2020

testing CI, reopen later

@iche033 iche033 closed this Jun 30, 2020
@iche033 iche033 reopened this Jun 30, 2020
iche033 added 4 commits June 30, 2020 16:09
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@chapulina
Copy link
Contributor

@iche033 , do you know what's the status of this PR, considering all the other Windows changes that have been merged recently?

@iche033
Copy link
Contributor Author

iche033 commented Jan 28, 2021

I'm still seeing error msgs in the windows CI build console:

Error while loading the library [D:\Jenkins\workspace\ign_rendering-pr-win\ws\install\ignition-rendering4\lib\ign-rendering-4\engine-plugins\ignition-rendering-ogre2.dll]: "D:\Jenkins\workspace\ign_rendering-pr-win\ws\install\ignition-rendering4\lib\ign-rendering-4\engine-plugins\ignition-rendering-ogre2.dll": The specified module could not be found.
59: �[31m[Err] [D:\Jenkins\workspace\ign_rendering-pr-win\ws\ign-rendering\src\RenderEngineManager.cc:470] �[m�[31mFailed to load plugin [�[m�[31mignition-rendering-ogre2�[m�[31m] : couldn't load library on path [�[m�[31mD:\Jenkins\workspace\ign_rendering-pr-win\ws\install\ignition-rendering4\lib\ign-rendering-4\engine-plugins\ignition-rendering-ogre2.dll�[m�[31m].�[m�[31m

but the tests are actually passing which makes me wonder if these msgs are a red herring.

@iche033
Copy link
Contributor Author

iche033 commented Dec 24, 2021

closing this PR as I haven't had time to get back to this.

@iche033 iche033 closed this Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants