Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make detail symbols hidden #250

Closed
wants to merge 1 commit into from
Closed

make detail symbols hidden #250

wants to merge 1 commit into from

Conversation

adlarkin
Copy link
Contributor

Signed-off-by: Ashton Larkin [email protected]

Summary

After noticing that a detail class in ign-gazebo was not marked as hidden (gazebosim/gz-sim#759), I looked through the other ignition repositories and found that there are a few detail symbols in ign-physics that should be marked as hidden as well.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See
    contributing)
  • All tests passed (See
    test coverage)
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ashton Larkin <[email protected]>
@adlarkin adlarkin requested a review from j-rivero April 26, 2021 19:41
@adlarkin adlarkin requested a review from mxgrey as a code owner April 26, 2021 19:41
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 26, 2021
@adlarkin
Copy link
Contributor Author

@j-rivero I'm already seeing some issues in CI: https://github.com/ignitionrobotics/ign-physics/pull/250/checks?check_run_id=244178102

I'm not sure what we need to do here, but @chapulina mentioned: "We should be able to hide all the details without thinking twice. If this causes some issue on tests or examples, this probably means that those classes shouldn't be in detail."

@scpeters
Copy link
Member

@j-rivero I'm already seeing some issues in CI: https://github.com/ignitionrobotics/ign-physics/pull/250/checks?check_run_id=244178102

I'm not sure what we need to do here, but @chapulina mentioned: "We should be able to hide all the details without thinking twice. If this causes some issue on tests or examples, this probably means that those classes shouldn't be in detail."

from the CI results, it looks like we can't hide detail headers

@scpeters scpeters closed this Apr 28, 2021
@adlarkin adlarkin deleted the adlarkin/detail_hidden branch April 28, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants