Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols of detail::View class are public #759

Closed
adlarkin opened this issue Apr 13, 2021 · 2 comments
Closed

Symbols of detail::View class are public #759

adlarkin opened this issue Apr 13, 2021 · 2 comments
Assignees

Comments

@adlarkin
Copy link
Contributor

When working on #752, it became apparent that the detail::View class has public visibility. This makes it difficult to change things in this class since it will break ABI. Considering the fact that detail classes were never intended to be used by external users, we should probably make the visibility of this class hidden. I believe that this could be as simple as switching detail::View's visibility to IGNITION_GAZEBO_HIDDEN for Fortress, but as @iche033 pointed out, we will need to test this to ensure that other platforms and libraries aren't broken by this change.

@chapulina, what do you think about this? Are there any reasons why we should keep the visibility of detail::View (and anything else in detail) public, or are we okay to make the change to hidden?

@chapulina
Copy link
Contributor

Ahh that's unfortunate. We should hide everything inside detail.

@adlarkin
Copy link
Contributor Author

I'm closing this since #788 was merged (it should have closed automatically since this issue was linked to #788, but for some reason, it didn't 🤷‍♂️)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants