Use [gs]etPrimarySlipCompliance API with dart 6.10.0 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These APIs are used in the upstream release of dartsim 6.10.0 but are missing from our fork. We should add them to the fork and build more debs before merging this. Signed-off-by: Steve Peters <[email protected]>
5 tasks
|
updating the fork in gazebo-forks/dart#23 |
chapulina
added
the
needs upstream release
5 tasks
This was referenced May 14, 2021
|
I'll submit this first to ign-physics2 then merge forward |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Report
Fixes API incompatibility between upstream and our fork of dart
Summary
The upstream dartsim 6.10.1 release contains
DynamicsAspect::getPrimarySlipComplianceandDynamics::setPrimarySlipComplianceAPIs. Our fork, however, only containsDynamicsAspect::getSlipComplianceandDynamicsAspect::setSlipCompliance. This PR changesign-physics4to use the upsteam APIs and should be merged once a matching API has been added to our fork and new binary packages have been built.Checklist
codecheckpassed (Seecontributing)
test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge