Remove deprecations: tock #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
|
CI isn't happy, I'm looking at it... |
jennuine
reviewed
Dec 2, 2024
test/integration/camera_tracking.cc
Outdated
Comment on lines
182
to
198
| // Follow | ||
| result = false; | ||
| executed = node.Request("/gui/follow", req, timeout, rep, result); | ||
| EXPECT_TRUE(executed); | ||
| EXPECT_TRUE(result); | ||
| EXPECT_TRUE(rep.data()); | ||
|
|
||
| msgs::Vector3d reqOffset; | ||
| reqOffset.set_x(1.0); | ||
| reqOffset.set_y(1.0); | ||
| reqOffset.set_z(1.0); | ||
| result = false; | ||
| executed = node.Request("/gui/follow/offset", reqOffset, timeout, rep, | ||
| result); | ||
| EXPECT_TRUE(executed); | ||
| EXPECT_TRUE(result); | ||
| EXPECT_TRUE(rep.data()); |
There was a problem hiding this comment.
Instead of removing, we should update the test to use /gui/track. I believe the test is failing because we aren't requesting the camera to track the object.
There was a problem hiding this comment.
Thanks for the suggestion, fixed in 5604930.
Signed-off-by: Carlos Agüero <[email protected]>
jennuine
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Thanks Carlos! Do you mind to add this deprecation to https://github.com/gazebosim/gz-gui/blob/main/Migration.md please? Otherwise LGTM.
Signed-off-by: Carlos Agüero <[email protected]>
jennuine
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Perform the tock of the tick-tock cycle and remove / move deprecated code.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.