Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port: 8 to main #581

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Forward port: 8 to main #581

merged 10 commits into from
Oct 5, 2023

Conversation

mjcarroll
Copy link
Contributor

➡️ Forward port

Port gz-gui8 to main

Branch comparison: main...gz-gui8

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@mjcarroll mjcarroll requested a review from jennuine as a code owner October 5, 2023 19:34
@mjcarroll mjcarroll changed the title Ports/8 to main Forward port: 8 to main Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #581 (4f86622) into main (c020e25) will decrease coverage by 2.85%.
Report is 20 commits behind head on main.
The diff coverage is 29.51%.

❗ Current head 4f86622 differs from pull request most recent head b3ed6bd. Consider uploading reports for the commit b3ed6bd to get more accurate results

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   70.91%   68.07%   -2.85%     
==========================================
  Files          45       38       -7     
  Lines        4941     5369     +428     
==========================================
+ Hits         3504     3655     +151     
- Misses       1437     1714     +277     
Files Coverage Δ
include/gz/gui/Helpers.hh 77.77% <ø> (ø)
include/gz/gui/Plugin.hh 100.00% <ø> (ø)
src/MainWindow.cc 95.68% <100.00%> (+0.45%) ⬆️
src/Plugin.cc 83.19% <ø> (+1.68%) ⬆️
src/gz.cc 42.00% <ø> (-0.86%) ⬇️
src/plugins/camera_tracking/CameraTracking.cc 70.55% <ø> (+1.50%) ⬆️
src/plugins/image_display/ImageDisplay.cc 93.16% <100.00%> (+0.36%) ⬆️
src/plugins/marker_manager/MarkerManager.cc 58.82% <100.00%> (-0.60%) ⬇️
src/plugins/world_control/WorldControl.cc 72.66% <ø> (+0.06%) ⬆️
src/Helpers.cc 91.42% <77.77%> (-2.05%) ⬇️
... and 7 more

... and 26 files with indirect coverage changes

@mjcarroll mjcarroll merged commit cfc1bf7 into main Oct 5, 2023
8 of 9 checks passed
@mjcarroll mjcarroll deleted the ports/8_to_main branch October 5, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants