-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes ignition for gz in tutorial commands #570
Conversation
@@ -98,14 +98,14 @@ Build and install as follows: | |||
|
|||
1. Clone the repository | |||
``` | |||
git clone https://github.com/gazebosim/gz-gui -b ign-gui<#> | |||
git clone https://github.com/gazebosim/gz-gui -b gz-gui<#> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note that if the version is > gui7
then to use ign-
? It also might be good to add a link to this post: https://community.gazebosim.org/t/a-new-era-for-gazebo/1356
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Could you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Statement looks good, do you mind putting it closer to the beginning of this document, right above Binary Install
heading here:
gz-gui/tutorials/01_install.md
Lines 17 to 18 in db15648
## Binary Install |
I'd make sure to add a empty row before and afterwards so the Note
is on it's own line, rather than part of the previous sentence.
Codecov Report
@@ Coverage Diff @@
## gz-gui8 #570 +/- ##
========================================
Coverage 68.10% 68.10%
========================================
Files 38 38
Lines 5367 5367
========================================
Hits 3655 3655
Misses 1712 1712 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small nit :)
@@ -98,14 +98,14 @@ Build and install as follows: | |||
|
|||
1. Clone the repository | |||
``` | |||
git clone https://github.com/gazebosim/gz-gui -b ign-gui<#> | |||
git clone https://github.com/gazebosim/gz-gui -b gz-gui<#> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Statement looks good, do you mind putting it closer to the beginning of this document, right above Binary Install
heading here:
gz-gui/tutorials/01_install.md
Lines 17 to 18 in db15648
## Binary Install |
I'd make sure to add a empty row before and afterwards so the Note
is on it's own line, rather than part of the previous sentence.
Can you sign commits please: https://github.com/gazebosim/gz-gui/pull/570/checks?check_run_id=16804603853 For future, when making commits, you can do |
Sure thing. I'm not sure why this is happening, I usually just do |
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Voldivh <[email protected]>
5a5a54c
to
15df2c9
Compare
That works too. I believe your first and last commit were signed but the two middle ones weren't. If you like, there is a way to set this up automatically so you don't always have to remember |
Thanks Jenn, I'll take a look into it. Could have easily missed a couple by accident :D |
🦟 Bug fix
Fixes gazebosim/gazebo_test_cases#564
Summary
Changes the use of
ignition
forgz
in tutorial commands.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.