Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration : gz-gui #401

Merged
merged 25 commits into from
May 29, 2022
Merged

ign -> gz Namespace Migration : gz-gui #401

merged 25 commits into from
May 29, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022
@methylDragon methylDragon mentioned this pull request May 18, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label May 18, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 18, 2022
@methylDragon methylDragon force-pushed the namespace_migration branch 6 times, most recently from a2ba942 to f3be1d1 Compare May 20, 2022 09:45
chapulina
chapulina suggested changes May 25, 2022
View reviewed changes
examples/plugin/gz_components/GzComponents.cc Show resolved Hide resolved
include/gz/gui/config.hh.in Outdated Show resolved Hide resolved
src/plugins/transport_scene_manager/TransportSceneManager.hh Outdated Show resolved Hide resolved
tutorials/08_screenshot.md Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch from e7fbb8b to b661375 Compare May 25, 2022 21:09
@methylDragon methylDragon mentioned this pull request May 25, 2022
Merged
@chapulina
Copy link
Contributor

#406 is merged, this PR needs a merge / rebase

methylDragon added 12 commits May 27, 2022 16:11
@methylDragon
Update header guards
ef90973 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate namespaces
2025559 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Add migration line
5289c60 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Implement deprecation trick
9d444cd 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Add deprecation test
71d0686 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Include config.hh
70bb4ac 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Use pragma deprecation message instead
1beacd9 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Ticktock config macros
f84d4fe 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Mention gz headers in migration
937b6d9 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate includes to gz
76f3166 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Update config.hh
32a2d3d 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate Export.hh headers and deprecated test
3645e3f 
Signed-off-by: methylDragon <[email protected]>
methylDragon added 13 commits May 27, 2022 16:11
@methylDragon
Migrate IGN(ITION)_GUI_XXX macros and variables
6c99f4f 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate github links
27b79af 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate user-facing Ignition to Gazebo
00e0685 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate gz-common logging calls
ae6f7a4 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate "ignition.msgs" -> "gz.msgs"
0a17693 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix deprecated test
eedc3a6 
Creating a Dialog without any args and not using it somehow causes a segfault just in the deprecated test. This commit makes the test use a different object instead.

Signed-off-by: methylDragon <[email protected]>
@methylDragon
Include config.hh in recursive directories and <lib>.hh
420a138 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Include config.hh in .h and .hpp redirection headers
cde12ae 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
ignitionrobotics -> gazebosim
8dcc9b6 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Rollback osrf-migration.github.io migrations
e5ab24f 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix typo
b8d8166 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Wording changes
fda266f 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate igndbg -> gzdbg
f468d6e 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the namespace_migration branch from 6d112c3 to f468d6e Compare May 27, 2022 23:12
@methylDragon
Copy link
Contributor Author

Rebased!

chapulina
chapulina approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI!

@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented May 29, 2022 •
edited
Loading

Codecov Report

Merging #401 (f468d6e) into main (2c5d186) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   30.03%   30.03%           
=======================================
  Files          43       43           
  Lines        1888     1888           
=======================================
  Hits          567      567           
  Misses       1321     1321
Impacted Files Coverage Δ
src/plugins/scene3d/moc_Scene3D.cpp 39.41% <0.00%> (ø)
src/plugins/publisher/moc_Publisher.cpp 18.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5d186...f468d6e. Read the comment docs.

@methylDragon methylDragon merged commit cf54ba2 into main May 29, 2022
@methylDragon methylDragon deleted the namespace_migration branch May 29, 2022 02:35
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina