Fix ColladaLoader loading <transparent> tag when <transparency> does not exist #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
github-actions
bot
added
🏰 citadel
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-common3 #68 +/- ##
===============================================
+ Coverage 73.79% 73.80% +0.01%
===============================================
Files 68 68
Lines 9257 9261 +4
===============================================
+ Hits 6831 6835 +4
Misses 2426 2426
Continue to review full report at Codecov.
|
mjcarroll
approved these changes
May 27, 2020
chapulina
approved these changes
Jun 5, 2020
mjcarroll
pushed a commit
that referenced
this pull request
Oct 14, 2020
…not exist (#68) * fix loading <transparent> when <transparency> does not exist Signed-off-by: Ian Chen <[email protected]>
mjcarroll
pushed a commit
that referenced
this pull request
Oct 19, 2020
…not exist (#68) * fix loading <transparent> when <transparency> does not exist Signed-off-by: Ian Chen <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading
<transparent>tag in our current implementation, we use a transparency value of 0.0 if<transparency>does not tag exist. But according to collada 1.5 spec chapter 7-6, page 250:This causes some meshes to be transparent, see gazebosim/gz-rendering#89. This PR fixes the default value used in calculation.
Signed-off-by: Ian Chen [email protected]