Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Avoid Io.hh header name clash (#471) #472

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Oct 26, 2022

Cherry-picked #471.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@hidmic hidmic added the 🌱 garden Ignition Garden label Oct 26, 2022
@hidmic hidmic requested a review from mjcarroll as a code owner October 26, 2022 20:12
@mjcarroll mjcarroll enabled auto-merge (squash) October 26, 2022 20:14
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #472 (d0fa8b8) into gz-common5 (56b82ad) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           gz-common5     #472   +/-   ##
===========================================
  Coverage       80.60%   80.60%           
===========================================
  Files              90       90           
  Lines           10237    10237           
===========================================
  Hits             8252     8252           
  Misses           1985     1985           
Impacted Files Coverage Δ
io/include/gz/common/DataFrame.hh 78.12% <ø> (ø)
io/include/gz/common/IOBase.hh 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 9521e1b into gz-common5 Oct 26, 2022
@mjcarroll mjcarroll deleted the hidmic/garden/backport-io-name-fix branch October 26, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants