Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Io.hh header name clash #471

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Avoid Io.hh header name clash #471

merged 1 commit into from
Oct 26, 2022

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Oct 26, 2022

🦟 Bug fix

Fixes #470.

Summary

More of a hunch than a fix. I suspect neither Mac OS nor Windows do case sensitive header look up, which creates a clash between the Io.hh file and the generated io.hh file.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michel Hidalgo <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #471 (376d299) into main (9ece5b5) will not change coverage.
The diff coverage is n/a.

❗ Current head 376d299 differs from pull request most recent head 769a992. Consider uploading reports for the commit 769a992 to get more accurate results

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files          79       79           
  Lines        9679     9679           
=======================================
  Hits         7847     7847           
  Misses       1832     1832           
Impacted Files Coverage Δ
io/include/gz/common/DataFrame.hh 76.27% <ø> (ø)
io/include/gz/common/IOBase.hh 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll
Copy link
Contributor

Yep, this is very likely the fix.

@mjcarroll mjcarroll merged commit b0001bf into main Oct 26, 2022
@mjcarroll mjcarroll deleted the hidmic/rename-io-header branch October 26, 2022 20:05
@hidmic
Copy link
Contributor Author

hidmic commented Oct 26, 2022

Would you mind releasing this @mjcarroll ?

@mjcarroll
Copy link
Contributor

Ah yeah, in order for it to be released, we need to target something other than main. Can this land on garden?

hidmic added a commit that referenced this pull request Oct 26, 2022
mjcarroll pushed a commit that referenced this pull request Oct 26, 2022
Backports #471 to Garden.

Signed-off-by: Michel Hidalgo <[email protected]>
@scpeters
Copy link
Member

an alternative is to nest the headers of components in a subfolder like gz/common/io/Io.hh

@hidmic
Copy link
Contributor Author

hidmic commented Oct 26, 2022

There was no fundamental reason to name that header Io.hh, so no biggie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants