-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Io.hh header name clash #471
Conversation
Signed-off-by: Michel Hidalgo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 79 79
Lines 9679 9679
=======================================
Hits 7847 7847
Misses 1832 1832
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yep, this is very likely the fix. |
Would you mind releasing this @mjcarroll ? |
Ah yeah, in order for it to be released, we need to target something other than |
Signed-off-by: Michel Hidalgo <[email protected]>
Backports #471 to Garden. Signed-off-by: Michel Hidalgo <[email protected]>
an alternative is to nest the headers of components in a subfolder like |
There was no fundamental reason to name that header |
🦟 Bug fix
Fixes #470.
Summary
More of a hunch than a fix. I suspect neither Mac OS nor Windows do case sensitive header look up, which creates a clash between the
Io.hh
file and the generatedio.hh
file.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.