-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some tests for parentPath/basename #309
Conversation
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-common4 #309 +/- ##
============================================
Coverage 77.02% 77.02%
============================================
Files 76 76
Lines 10729 10729
============================================
Hits 8264 8264
Misses 2465 2465 Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with happy CI.
Note that the absolute parentPath
test is having different results for Windows on this branch and on main
with #308
- Here:
EXPECT_EQ(parentPath(absolute), "home\\bob")
- On
main
:EXPECT_EQ(parentPath(absolute), "\\home\\bob")
If we consider the behaviour on this branch to be correct (since it's a stable version), then a fix should go into main
later. Otherwise, if we think this branch is wrong, we could change the behaviour here and document it in the migration guide (but that may affect users).
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Verify the behavior of parentPath and basename in ign-common4 to assert that #308 is correct.