Fix filesystem::separator behavior #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 76.74% 76.75%
=======================================
Files 75 75
Lines 10325 10328 +3
=======================================
+ Hits 7924 7927 +3
Misses 2401 2401
Continue to review full report at Codecov.
|
mjcarroll
force-pushed
the
remove_boost_tests
branch
from
6138199 to
0038e2f
Compare
mjcarroll
force-pushed
the
filesystem_bugfix
branch
from
72c9f6c to
10f0df8
Compare
mjcarroll
force-pushed
the
remove_boost_tests
branch
2 times, most recently
from
c7c2b44 to
798821b
Compare
mjcarroll
force-pushed
the
filesystem_bugfix
branch
from
10f0df8 to
2bb1fd5
Compare
iche033
reviewed
Feb 9, 2022
mjcarroll
force-pushed
the
filesystem_bugfix
branch
2 times, most recently
from
fb40333 to
0bc6478
Compare
Signed-off-by: Michael Carroll <[email protected]>
* Separator with an emptry string argument should return the preferred separator for that platform * Basename should return basename in the case with multiple trailing slashes Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
filesystem_bugfix
branch
from
0bc6478 to
3e101f8
Compare
7 tasks
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, separator's behavior was not matching the
ign-common5behavior. Passing an empty string should return the preferred separator for the operating system. We were not currently testing for this.