Fix bug in URIPath assignment operator #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
github-actions
bot
added
🌱 garden
Codecov Report
@@ Coverage Diff @@
## ign-common4 #275 +/- ##
============================================
Coverage 77.10% 77.11%
============================================
Files 75 75
Lines 10694 10695 +1
============================================
+ Hits 8246 8247 +1
Misses 2448 2448
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Dec 4, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
scpeters
added a commit
to gazebosim/gz-fuel-tools
that referenced
this pull request
Mar 6, 2022
Follow up to gazebosim/gz-common#275 Signed-off-by: Steve Peters <[email protected]>
7 tasks
chapulina
pushed a commit
to gazebosim/gz-fuel-tools
that referenced
this pull request
Mar 7, 2022
Follow up to gazebosim/gz-common#275 Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Discovered in #274.
Summary
The issue is that the
URIPath::Implementationstruct has atrailingSlashmember: https://github.com/ignitionrobotics/ign-common/blob/ign-common4/src/URI.cc#L54-L73The originally written copy-assignment operator doesn't copy this member:
https://github.com/ignitionrobotics/ign-common/blob/ign-common4/src/URI.cc#L586-L591
And the test exercises this copy-assignment:
https://github.com/ignitionrobotics/ign-common/blob/ign-common4/src/URI_TEST.cc#L890-L894
In this case,
ImplPtrhas shown that the previous behavior is actually a bug, and we should fix it in previous versions.Note to maintainers: Remember to use Squash-Merge