Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C4307 warning #198

Merged

Conversation

mjcarroll
Copy link
Contributor

@ahcorde I just checked this with compiler explorer, this should be sufficient to clear the warning.

Signed-off-by: Michael Carroll [email protected]

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from ahcorde April 9, 2021 14:03
@mjcarroll mjcarroll mentioned this pull request Apr 9, 2021
7 tasks
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #198 (1a92f0b) into ahcorde/improve/windows_support (31a1468) will not change coverage.
The diff coverage is n/a.

❗ Current head 1a92f0b differs from pull request most recent head 3194132. Consider uploading reports for the commit 3194132 to get more accurate results
Impacted file tree graph

@@                       Coverage Diff                        @@
##           ahcorde/improve/windows_support     #198   +/-   ##
================================================================
  Coverage                            75.07%   75.07%           
================================================================
  Files                                   72       72           
  Lines                                10260    10260           
================================================================
  Hits                                  7703     7703           
  Misses                                2557     2557           
Impacted Files Coverage Δ
include/ignition/common/Util.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a1468...3194132. Read the comment docs.

@mjcarroll mjcarroll merged commit c5caa4d into ahcorde/improve/windows_support Apr 9, 2021
@mjcarroll mjcarroll deleted the mjcarroll/suggestions_197 branch April 9, 2021 14:31
ahcorde added a commit that referenced this pull request Apr 12, 2021
* Improved Windows support

Signed-off-by: ahcorde <[email protected]>

* Fix C4307 warning (#198)

Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant