Improved Windows support

[ahcorde]

Signed-off-by: ahcorde [email protected]

🧑‍🏭 Improvement

Summary

Improved Windows support. This PR is required here gazebosim/gz-fuel-tools#178

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[codecov]

Codecov Report

Merging #197 (98173df) into ign-common3 (2582754) will decrease coverage by 0.09%.
The diff coverage is 34.78%.

❗ Current head 98173df differs from pull request most recent head c5caa4d. Consider uploading reports for the commit c5caa4d to get more accurate results

@@               Coverage Diff               @@
##           ign-common3     #197      +/-   ##
===============================================
- Coverage        75.16%   75.07%   -0.10%     
===============================================
  Files               72       72              
  Lines            10237    10260      +23     
===============================================
+ Hits              7695     7703       +8     
- Misses            2542     2557      +15     

Impacted Files	Coverage Δ
include/ignition/common/Util.hh	100.00% <ø> (ø)
src/Filesystem.cc	73.29% <0.00%> (-6.99%)	⬇️
src/URI.cc	98.48% <75.00%> (-0.29%)	⬇️
src/SystemPaths.cc	88.03% <100.00%> (+0.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2582754...c5caa4d. Read the comment docs.

[ahcorde]

There is an issue removing a TMP_*.mp4 file in one of tests. This is not making the test to fail but I think we can open an issue. Probably this is because the file is not closed.

[mjcarroll]

Can we add a test for the new functionality?

[ahcorde]

Can we add a test for the new functionality?

@mjcarroll, should we make this function a method (public or private)?

[mjcarroll]

@mjcarroll, should we make this function a method (public or private)?

We talked offline, this doesn't need to be a public method as it is just fixing tests. Codecov drop is because of Linux vs Windows execution paths.