Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport GZ_SANITIZER variable #294

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Backport GZ_SANITIZER variable #294

merged 3 commits into from
Aug 5, 2022

Conversation

scpeters
Copy link
Member

🎉 New feature

Backport a feature to simplify the fixing of cmake deprecation warnings in CI

Summary

This backports the GZ_SANITIZER variable so that it can be used in jenkins and fix some cmake deprecation warnings.

CMake Deprecation Warning at cmake/GzSanitizers.cmake:58 (message):
  Ign prefixed variable [IGN_SANITIZER] is deprecated! Use [GZ_SANITIZER]
  instead!
Call Stack (most recent call first):
  cmake/GzCMake.cmake:33 (include)
  CMakeLists.txt:19 (include)

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Backport GZ_SANITIZER variable
fa05ef5 
This will allow GZ_SANITIZER to be used in jenkins
and fix a cmake deprecation warning.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested review from mxgrey and j-rivero as code owners July 31, 2022 02:54
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jul 31, 2022
scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Jul 31, 2022
@scpeters
Use -DGZ_SANITIZER to fix deprecation warning
8afe92f 
Requires stable release of gazebosim/gz-cmake#294.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters mentioned this pull request Jul 31, 2022
Merged
chapulina
chapulina approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment about comments

cmake/IgnSanitizers.cmake Outdated Show resolved Hide resolved
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Aug 5, 2022
@chapulina chapulina merged commit 2566844 into ign-cmake2 Aug 5, 2022
@chapulina chapulina deleted the scpeters/backport_gz_sanitizer branch August 5, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11 ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @chapulina