Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -DGZ_SANITIZER to fix deprecation warning #776

Merged
merged 4 commits into from
Sep 4, 2022

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Jul 31, 2022

The Garden asan builds have cmake deprecation warnings due to the use of -DIGN_SANITIZER:

CMake Deprecation Warning at cmake/GzSanitizers.cmake:58 (message):
  Ign prefixed variable [IGN_SANITIZER] is deprecated! Use [GZ_SANITIZER]
  instead!
Call Stack (most recent call first):
  cmake/GzCMake.cmake:33 (include)
  CMakeLists.txt:19 (include)

To avoid having complex logic in the Jenkins script to determine which variable to use, the GZ_SANITIZER variable is backported to ign-cmake2 in gazebosim/gz-cmake#294.. Once that is merged and released, this PR can be marked ready for review. This pull request is ready for review.

Requires stable release of gazebosim/gz-cmake#294.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters marked this pull request as ready for review September 2, 2022 17:12
@scpeters scpeters requested a review from j-rivero as a code owner September 2, 2022 17:12
@scpeters scpeters merged commit 966c795 into master Sep 4, 2022
@scpeters scpeters deleted the scpeters/gz_sanitizer branch September 4, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants