Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 2.9.0 release #187

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Prepare for 2.9.0 release #187

merged 3 commits into from
Sep 2, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 1, 2021

🎈 Release

Preparation for <2.9.0> release.

Comparison to <x.y.z>: ignition-cmake2_2.8.0...ign-cmake2

Needed by gazebosim/sdformat#682

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • [ ] Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Addisu Z. Taddese <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Sep 1, 2021
Changelog.md Outdated
* [Pull request #186](https://github.com/ignitionrobotics/ign-cmake/pull/186)

1. Revert FindIgnOgre change
* [Pull request #184](https://github.com/ignitionrobotics/ign-cmake/pull/184)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is reverting #182? I would just remove both of them from the changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It's not a complete revert though since #182 removes a file. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really reverting #101, which was forward-ported in #182.

Btw, we messed up and squash merged #182 instead of creating a merge commit. That's probably why #101 didn't show up on the changelog and still shows in the branch comparison:

ign-cmake2...ign-cmake0

(CC @j-rivero )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then I would remove #182 and #184 from the changelog and just add an entry for #181 to represent the removed file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then I would remove #182 and #184 from the changelog and just add an entry for #181 to represent the removed file

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added #181 and removed #182 and #184 in db60cc7.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just needs a date adjustment

Changelog.md Outdated Show resolved Hide resolved
Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey merged commit 6c4e7da into ign-cmake2 Sep 2, 2021
@azeey azeey deleted the azeey/prep_2.9.0 branch September 2, 2021 16:27
srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants