-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 2.9.0 release #187
Conversation
Signed-off-by: Addisu Z. Taddese <[email protected]>
Changelog.md
Outdated
* [Pull request #186](https://github.com/ignitionrobotics/ign-cmake/pull/186) | ||
|
||
1. Revert FindIgnOgre change | ||
* [Pull request #184](https://github.com/ignitionrobotics/ign-cmake/pull/184) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is reverting #182? I would just remove both of them from the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. It's not a complete revert though since #182 removes a file. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Addisu Z. Taddese <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just needs a date adjustment
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
🎈 Release
Preparation for <2.9.0> release.
Comparison to <x.y.z>: ignition-cmake2_2.8.0...ign-cmake2
Needed by gazebosim/sdformat#682
Checklist
[ ] Updated migration guide (as needed)Note to maintainers: Remember to use Squash-Merge