Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ‘ฉโ€๐ŸŒพ Revert FindIgnOgre change #184

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 26, 2021

๐ŸฆŸ Bug fix

Summary

Testing fixes for regressions introduced with #182

Test build: Build Status

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ

https://github.com/osrf/buildfarmer/issues/224

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added Gazebo 1๏ธ1๏ธ Dependency of Gazebo classic version 11 ๐Ÿข edifice Ignition Edifice ๐Ÿฏ fortress Ignition Fortress ๐Ÿฐ citadel Ignition Citadel ๐Ÿ”ฎ dome Ignition Dome labels Aug 26, 2021
@chapulina chapulina changed the title Revert FindIgnOgre change ๐Ÿ‘ฉโ€๐ŸŒพ Revert FindIgnOgre change Aug 26, 2021
@chapulina chapulina marked this pull request as ready for review August 26, 2021 22:16
@mjcarroll mjcarroll merged commit ae1bbbf into ign-cmake2 Aug 27, 2021
@mjcarroll mjcarroll deleted the chapulina/2/revert branch August 27, 2021 16:02
@scpeters scpeters mentioned this pull request Sep 1, 2021
6 tasks
srmainwaring pushed a commit to srmainwaring/gz-cmake that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿฐ citadel Ignition Citadel ๐Ÿ”ฎ dome Ignition Dome ๐Ÿข edifice Ignition Edifice ๐Ÿฏ fortress Ignition Fortress Gazebo 1๏ธ1๏ธ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants