Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for GPU on WSL #4

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Aug 1, 2023

This PR backports the upstream fix OGRECave/ogre-next#388 to the ogre-next debian packages. I am not an expert of Debian packaging, so I could have done something wrong.

The change itself should only affect system that before this change were crashing with error "Ogre::UnimplementedException", and not do anything on system that are not crashing, so it should be relatively safe to merge.

cc @j-rivero @azeey @bperseghetti

@j-rivero
Copy link
Contributor

j-rivero commented Aug 1, 2023

Patch looks good to me, I added a minimal DEP-3 info in 352ab22

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that we want to a new release / prerelease, @traversaro ?

@traversaro
Copy link
Contributor Author

I assume that we want to a new release / prerelease, @traversaro ?

Yes, that would be great!

@j-rivero j-rivero merged commit 3cd2c93 into gazebo-forks:master Aug 2, 2023
@j-rivero
Copy link
Contributor

j-rivero commented Aug 2, 2023

I've released jammy/amd64 in the prerelease repository Build Status

Give a it a try and we can go to stable if there are no big failures on standard Linux and it improves the WSL experience.

@traversaro
Copy link
Contributor Author

I've released jammy/amd64 in the prerelease repository Build Status

Give a it a try and we can go to stable if there are no big failures on standard Linux and it improves the WSL experience.

Ok, even if at the moment my GPU acceleration is not working in WSL, so I can only test if it is working fine outside of WSL.

@bperseghetti if you are interested in speed up this, do you think you or someone else interested in WSL support can test this? Unfortunatly the changes necessary in gz-rendering ( gazebosim/gz-rendering#851 ) are still not released, but I guess installing ogre-next from the prerelease repo and compiling gz-garden from source from the latest commit in the branch should be sufficient to test if gazebosim/gz-sim#920 is solved.

@PetervdPerk-NXP
Copy link

Just compiled the latest master of gazebo and used the ogre-next deb build.
Testing on my windows machine seems to be running fine now, Thanks!

WSL version: 1.2.5.0
Kernel version: 5.15.90.1
WSLg version: 1.0.51
Mesa 23.1.4 - kisak-mesa PPA

@traversaro
Copy link
Contributor Author

Just compiled the latest master of gazebo and used the ogre-next deb build. Testing on my windows machine seems to be running fine now, Thanks!

WSL version: 1.2.5.0
Kernel version: 5.15.90.1
WSLg version: 1.0.51
Mesa 23.1.4 - kisak-mesa PPA

Great, thanks @PetervdPerk-NXP !

@bperseghetti
Copy link

@bperseghetti if you are interested in speed up this, do you think you or someone else interested in WSL support can test this? Unfortunatly the changes necessary in gz-rendering ( gazebosim/gz-rendering#851 ) are still not released, but I guess installing ogre-next from the prerelease repo and compiling gz-garden from source from the latest commit in the branch should be sufficient to test if gazebosim/gz-sim#920 is solved.

I passed the PR onto @PetervdPerk-NXP. Thanks once again @traversaro and @j-rivero. And thanks for testing @PetervdPerk-NXP.

@j-rivero
Copy link
Contributor

j-rivero commented Aug 3, 2023

Thanks for the testing. Released into stable Build Status

j-rivero added a commit that referenced this pull request Sep 12, 2023
Backport fix for GPU on WSL
j-rivero added a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants