Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OgreNext: Fix shaders compilation on d3d12 mesa driver (WSLg) #851

Merged
merged 2 commits into from
May 22, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented May 21, 2023

🦟 Bug fix

Fixes part of gazebosim/gz-sim#920 and of #852 .

Summary

Old GPUs and systems with incomplete GL implementations like WSLg would trigger shader compiler errors for several reasons:

  • because C++ saw that GL_ARB_shader_storage_buffer_object was supported but we didn't request it in the shader.
  • because C++ required the use of GLSL 4.30 (not supported by d3d12 as of 2023/05), even if GLSL 4.20 plus some extensions would also work fine.

This was tested on both mesa 22.2.5 and 23.1.0 .

The fix is actually from @darksylinc, see OGRECave/ogre-next@5b6d444 and OGRECave/ogre-next@3d9d380 for the original commits.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #851 (f6ab5f8) into gz-rendering7 (ef4abec) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f6ab5f8 differs from pull request most recent head 52f7af1. Consider uploading reports for the commit 52f7af1 to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #851   +/-   ##
==============================================
  Coverage          77.14%   77.14%           
==============================================
  Files                170      170           
  Lines              14716    14716           
==============================================
+ Hits               11352    11353    +1     
+ Misses              3364     3363    -1     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants