OgreNext: Fix shaders compilation on d3d12 mesa driver (WSLg) #851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes part of gazebosim/gz-sim#920 and of #852 .
Summary
Old GPUs and systems with incomplete GL implementations like WSLg would trigger shader compiler errors for several reasons:
This was tested on both mesa 22.2.5 and 23.1.0 .
The fix is actually from @darksylinc, see OGRECave/ogre-next@5b6d444 and OGRECave/ogre-next@3d9d380 for the original commits.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.