Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www/starters] add starter library submission instructions and button #8602

Merged

Conversation

amberleyromo
Copy link
Contributor

Closes #6704 and #7753.

@amberleyromo amberleyromo requested a review from a team September 28, 2018 00:36
@amberleyromo amberleyromo requested a review from a team as a code owner September 28, 2018 00:36
@amberleyromo
Copy link
Contributor Author

(This doesn't need to be blocked like the other library-related PRs currently blocked by
#8517 / #8320)

Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and one question that might be a change.


## Steps

There are only two major steps :)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to make this a bit more descriptive. Maybe something like this?

## How to Add Your Site to the Starter Library

To get your site added to the starter library, follow the two steps below.

Saying two "major" steps made me think there might be a lot of minor steps hidden in there. (Also I might be overthinking this.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be overthinking, but also no problem with changing it! It's modelled after the site submission and creator submission pages.

- Categories and tags for blog posts with pagination
```

Check out the `starters.yml` file for examples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well. I didn't because it's linked above (I just did it as an extra supporting note) but it sure doesn't hurt!

- url: Link to a demo of your starter
repo: Link to GitHub repo
description: Your starter description
# These correspond to the category filters in the library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more specific word than "these"? At first I thought it referred to the description. Most devs probably won't unless they are new-ish and not used to commenting...which probably always comes before the line the comment is about, I'm assuming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants